On Thu, 12 Sep 2024 15:01:59 GMT, Kevin Driver <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test enhancements
>
> test/jdk/sun/security/tools/jarsigner/RemovedFiles.java line 52:
>
>> 50:
>> 51: // Remove an entry after signing. There will be a warning.
>> 52: JarUtils.deleteEntries(Path.of("a.jar"), "a");
>
> No need to verify the execution was successful? Is throwing an IOException
> the only "unexpected" outcome?
I can imagine some info on whether the entry is really removed or not could be
useful for someone, I'll make an update to the `deleteEntries` method. But, I
don't want to care about it here. The next lines will confirm the removal.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19599#discussion_r1757108502
