On Fri, 27 Sep 2024 13:49:57 GMT, Sean Mullan <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> expected result should be the 1st argument
>
> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java
> line 182:
>
>> 180: {"key.bit.eccurve.disabled", "%1$d-bit %2$s key (disabled)"},
>> 181: {"unknown.size", "unknown size"},
>> 182: {"nonexistent.entries.found", "Nonexistent signed entries
>> detected. See details in -verbose output."},
>
> For the second sentence, in other warning messages, we say "Re-run jarsigner
> with the -verbose option for more details." Perhaps we should be consistent?
Actually, I see the output will also contain the message "Re-run with the
-verbose and -certs options for more details." so I take back my comment above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19599#discussion_r1778680492
