On Wed, 9 Oct 2024 18:53:39 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix decoding non-encrypted types
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 93:
>
>> 91: * Creates a immutable instance with a specific KeyFactory and/or
>> password.
>> 92: * @param withFactory KeyFactory provider
>> 93: * @param withPassword char[] password for EncryptedPrivateKeyInfo
>
> Should `EncryptedPrivateKeyInfo` be surrounded by `{@code}`?
Also, I suggest something to the effect of "the char array is cloned to prevent
subsequent modification"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1794043454
