On Tue, 15 Oct 2024 18:37:38 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > running the Exhaustive test through a more ruthless formatter test/jdk/com/sun/crypto/provider/KDF/HKDFExhaustiveTest.java line 298: > 296: Utils.runAndCheckException( > 297: () -> KDF.getInstance(KDF_ALGORITHMS[0], (KDFParameters) new > KDFAlgorithmParameterSpec()), > 298: ClassCastException.class); The ClassCastException is the result of line 297? I don't see the reason for testing this, seems nothing to do with the KDF impls? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1802105529