On Tue, 29 Oct 2024 15:56:50 GMT, Fernando Guallini <fguall...@openjdk.org> wrote:
>> Several tests are identified to use weak/legacy algorithms. As these tests >> purpose is not to exercise weak algorithms, these are updated in this PR to >> use stronger algorithms. If the test uses a weak key, it is updated as well. > > Fernando Guallini has updated the pull request incrementally with one > additional commit since the last revision: > > add more algos to TestExplicitKeyLength.java Wherever you have added a stronger algorithm to test is fine with me. But in some tests, where possible, instead of replacing the weak algorithm, the test should be updated to run against weak and strong algorithm. For example, in `test/jdk/com/sun/crypto/provider/Cipher/KeyWrap/TestCipherKeyWrapperTest.java`, test should be run with `DES` and `AES` algorithms. Changes to key size are fine. The changes in this PR should not be integrated until https://github.com/openjdk/jdk/pull/21537 is integrated. The updates in SecurityUtils should be used from https://github.com/openjdk/jdk/pull/21537. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21578#issuecomment-2447950852 PR Comment: https://git.openjdk.org/jdk/pull/21578#issuecomment-2447955270
