On Wed, 30 Oct 2024 18:12:30 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a >> system property, test.provider.name. If the property is not specified, the >> provider originally used in the test is used: >> >> Cipher c = Cipher.getInstance("AES/GCM/NoPadding", >> System.getProperty("test.provider.name", "SunJCE")); > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: > > included additional services in testing.md Approving but I recommend a follow-on task be filed to check if some of these hard-coded providers are really necessary. ------------- Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21551#pullrequestreview-2405973613