On Fri, 1 Nov 2024 16:25:25 GMT, Weijun Wang <[email protected]> wrote:
>> Here we have a launcher and several algorithm-specific tests. Users can
>> populate "internalProjection.json" files generated by NIST's ACVP Server
>> into the `data` directory and test them with the launcher.
>>
>> Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> acvp.test.alg system property
test/jdk/sun/security/provider/acvp/Launcher.java line 50:
> 48:
> 49: public static void main(String[] args) throws Exception {
> 50:
Use of properties to configure the test is a bit puzzling since the test is a
main(String[] args) program.
It would more convenient to run it from the command line (where it would be run
manually) to use normal arguments.
It would be better to describe the properties, if retained, as "test
properties", not system properties since they only apply to the test and not
the implementation. A "test." prefix on the property names would also make it
clearer.
Including sample `* @run main/manual ...` lines might show more easily how they
would be used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1826038029
