On Fri, 1 Nov 2024 22:41:32 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove logging
>
> src/java.base/share/classes/sun/security/ssl/SSLCipher.java line 1864:
>
>> 1862: // Check for unexpected plaintext alert.
>> 1863: if (contentType == ContentType.ALERT.id
>> 1864: && bb.remaining() == 2) {
>
> Minor nit. `if` continuation lines should be 8 spaces. e.g.
>
> if (this > that
> && big > little) {
> doSomethingElse();
> }
>
> ([Oracle Java Code Style
> Guidelines](https://www.oracle.com/technetwork/java/codeconventions-150003.pdf)
> Section 4: `Line wrapping for if statements should generally use the
> 8-space rule, since conventional (4
> space) indentation makes seeing the body difficult.`)
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21043#discussion_r1828087604
