On Tue, 5 Nov 2024 15:51:58 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> When an exception happens inside these stringToKey() methods, it returns a >> null. This would lead to unexpected NPE some time in the future. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > let it throw NSAE There is already a check for a `null` return value in one of the `EncryptedKey` constructors - did you consider instead adding a similar check in the other ctor? ------------- PR Comment: https://git.openjdk.org/jdk/pull/21908#issuecomment-2462953523