On Sat, 9 Nov 2024 02:07:03 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> keep expand option and add test coverage
>
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 91:
>
>> 89: System.err.println();
>> 90: System.err.println("help print the help messages");
>> 91: System.err.println("expand expand debugging
>> information");
>
> Why are we tossing `expand`? I quickly looked at the CSR, but the rationale
> didn't really gel. It wasn't mentioned in the actual bug report either.
> I'll look more next week.
>
> Anyway, if we decide this is in the best interest of the platform, then you
> should also delete the `useCompactFormat` and friends in the SSLConsoleLogger.
good point. I think it might have been wiped away in earlier iterations. I've
added it back and added test coverage for this option. The separator logic for
such options isn't specified which makes coding more tricky. I've tried to keep
the syntax parsing flexible.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r1837963005
