On Tue, 12 Nov 2024 15:24:14 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> The current syntax of the jdk.tls.disabledAlgorithms makes it difficult to >> disable algorithms that affect both the key exchange and authentication >> parts of a TLS cipher suite. For example, if you add "RSA" to the >> jdk.tls.disabledAlgorithms security property, it disables all cipher suites >> that use RSA, whether it is for key exchange or authentication. If you only >> want to disable cipher suites that use RSA for key exchange, the only >> workaround is to list the whole cipher suite name, so an exact match is >> done, but if there are many cipher suites that use that key exchange >> algorithm, this becomes cumbersome. > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Put the fail() within the try/catch-block, so we don't need to explictly > return in the catch-block src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java line 1003: > 1001: > 1002: // Exclude patterns from algorithm code flow. > 1003: patternStrings.forEach(disabledAlgorithms::remove); Did you consider calling `Set.iterator().remove()` while iterating over the `Set` instead? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21841#discussion_r1838551157
