On Thu, 14 Nov 2024 17:26:13 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comments from Kevin > > src/java.base/share/classes/com/sun/crypto/provider/CipherBlockChaining.java > line 63: > >> 61: >> 62: // chunkSize is multiple of block size, but otherwise fairly >> arbitrary >> 63: // Should be large enough to provide intrinsic with optimization > > Typo: `Should be small enough` I believe the original wording is correct: the more payload the intrinsic gets the better (eg. the intrinsic parallelizes decryption, at the cost of some initial setup. More payload amortizes the setup cost). But cannot be so large that the intrinsic locks up the VM (preventing GC), encrypting gigabytes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22086#discussion_r1844176958
