On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg <pminb...@openjdk.org> wrote:
> This PR proposes to use `StaticProperty.javaHome()` instead of > `System.getPropoerty("java.home")` in some internal classes. src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java line 52: > 50: > 51: private static final Path BOOT_MODULES_JIMAGE = > 52: Paths.get(StaticProperty.javaHome(),"lib", "modules"); The jimage and jrtfs files can't use internal APIs as they are compiled to --release 8 for jrt-fs.jar. There's a reminder of this in the class description but might be easy to miss. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22214#discussion_r1848210924