On Tue, 26 Nov 2024 00:26:54 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> SAP complains about SSLSocketNoServerHelloClientShutdown timing out in their
>> test environment (concurrent test execution with high CPU load). This change
>> addresses this issue in 2 ways:
>> - Increase default timeout value
>> - Allow adjustment of timeout value by setting "test.timeout.factor" system
>> property
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove timeout as JTREG has a default test timeout
test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java
line 101:
> 99: log(e.toString());
> 100: } finally {
> 101: serverLatch.countDown();
There should be a `latch.await()` at the `getInputStream()` above, as we want
to stall the start of the server handshaking until all of the client data has
been generated. (i.e. ClientHello/Alerts X 2).
test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java
line 168:
> 166: int len = clientSocketChannel.write(cTOs);
> 167:
> 168: serverLatch.await();
This should be a `latch.countDown()`, which releases the server thread.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22263#discussion_r1857533565
PR Review Comment: https://git.openjdk.org/jdk/pull/22263#discussion_r1857532762
