On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Now that JEP 486 has been integrated, `java.security` and `sun.security` >> implementation dependencies on `System.getSecurityManager` and >> `AccessController.doPrivileged` can be removed. >> >> This should cover most of the remaining cleanup in the security libraries >> area. A couple of the `sun.security.action` classes can't be removed yet, as >> well as a few constants in `sun.security.util.SecurityConstants` and >> internal `ProtectionDomain` methods until dependencies are removed in other >> areas. Some additional test cleanup can also be done later. > > Sean Mullan has updated the pull request incrementally with one additional > commit since the last revision: > > Removal of unused fields from AccessControlContext - no longer needed now > that VM cleanup is done. src/java.base/share/classes/java/security/Provider.java line 1: > 1: /* Hi @seanjmullan, This is very minor/nit, but, while adapting #15539 for the upcoming changes in this PR (and the whole work in [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411 "Implement JEP 486: Permanently Disable the Security Manager")), I found the following comments, which we will also want to remove. https://github.com/openjdk/jdk/blob/8abeb41b740534e832135a9e29f53460e4c509f2/src/java.base/share/classes/java/security/Provider.java#L348-L352 https://github.com/openjdk/jdk/blob/8abeb41b740534e832135a9e29f53460e4c509f2/src/java.base/share/classes/java/security/Provider.java#L779-L780 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22418#discussion_r1862456712
