On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov <aefi...@openjdk.org> wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and >> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and >> `jdk.naming.dns` modules. >> >> One noteworthy change: The `java.naming.rmi.security.manager` JNDI >> environment property can be used to setup the `SecurityManager`: if the >> property is added to an environment map the `RegistryContext` attempts to >> setup the `SecurityManager`. The environment property and related method are >> removed in this PR. >> >> `tier1` - `tier3`, and other non-tiered JNDI tests showed no failures >> related to this change. > > Aleksei Efimov has updated the pull request incrementally with one additional > commit since the last revision: > > Remove com.sun.jndi.ldap.VersionHelper > I'm thinking we could simply remove SecurityConstants when nothing references > it anymore - and not bother with removing its fields in the meantime. Would > you advise removing its other possibly unused fields? Sean has hollowed out SecurityConstants in pull/22418 but had to leave GET_CLASSLOADER_PERMISSION because of this usage. There will be many rounds of cleanup so doesn't matter if it comes later. ALL_PERMISSION will probably be the last one, don't know if Sean will get to this before the fork. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22421#issuecomment-2506524051
