On Tue, 3 Dec 2024 22:26:17 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> A few additional changes should be made to the API specs for these classes . >> These changes are documenting behavior of other APIs that has already been >> approved as part of JEP 486, so I don't think a CSR is necessary, but >> opinions on that are welcome. >> >> The `DomainCombiner` and `SubjectDomainCombiner` classes contain wording >> about "inherited" and"privileged" `ProtectionDomain`s which is no longer >> implemented, and so has been removed. The `PrivilegedAction` classes also >> contained wording about "privileged" computations which is no longer >> accurate. I also added an API note to these classes, similar to the ones in >> the `Permission` subclasses. Finally, I removed a couple of instances of >> "privileged work" from the `Subject` class which no longer applies. > > Sean Mullan has updated the pull request incrementally with one additional > commit since the last revision: > > Remove api notes. Marked as reviewed by weijun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/22500#pullrequestreview-2476901227