On Mon, 16 Dec 2024 15:05:38 GMT, Weijun Wang <[email protected]> wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated to use JarSigner.Builder.getDefaultDigestAlgorithm()
>
> test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java line
> 1442:
>
>> 1440:
>> 1441: String expectedTsaDigestAlg() {
>> 1442: return tsaDigestAlgorithm != null ? tsaDigestAlgorithm :
>> "SHA-256";
>
> You can actually get it from
> `jdk.security.jarsigner.JarSigner.Builder.getDefaultDigestAlgorithm()`.
I updated the code to use `getDefaultDigestAlgorithm` but I still need the
version-check because this test invokes jarsigner in different JDKs that use
different default algorithms.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22765#discussion_r1887015650
