On Sun, 8 Dec 2024 11:50:13 GMT, SendaoYan <s...@openjdk.org> wrote: > Hi all, > File src/java.smartcardio/share/native/libj2pcsc/pcsc.c and > src/jdk.crypto.cryptoki/share/native/libj2pkcs11/j2secmod.h generate compile > warning `'dprintf' macro redefined` by clang17/llvm17 with fastdebug > configure. This PR rename dprintf to debug_printf and make it variadic, to > avoid deplication macro definition to linux header > `/usr/include/bits/stdio2.h`, risk is low. > > Additional testing: > > - [x] build with fastdebug and release configure by gcc14 on linux-x64 > - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64 with release build > - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64 with fastdebug build > - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with release build > - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64 with fastdebug > build
This pull request has now been integrated. Changeset: 6c591854 Author: SendaoYan <s...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/6c59185475eeca83153f085eba27cc0b3acf9bb4 Stats: 52 lines in 5 files changed: 0 ins; 12 del; 40 mod 8345757: [ASAN] clang17 report 'dprintf' macro redefined Reviewed-by: kbarrett, valeriep ------------- PR: https://git.openjdk.org/jdk/pull/22630
