On Fri, 3 Jan 2025 02:01:13 GMT, Valerie Peng <valer...@openjdk.org> wrote:

>> Martin Balao has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Check disabled PKCS #11 mechanisms when concatenating keys and data.
>>   
>>   Co-authored-by: Martin Balao Alonso <mba...@redhat.com>
>>   Co-authored-by: Francisco Ferrari Bihurriet <fferr...@redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/CK_KEY_DERIVATION_STRING_DATA.java
>  line 53:
> 
>> 51:      * </pre>
>> 52:      */
>> 53:     public byte[] pData;
> 
> could be final.

Same goes to those in CK_HKDF_PARAMS class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1901421106

Reply via email to