On Thu, 23 Jan 2025 11:59:06 GMT, Mikhail Yankelevich <d...@openjdk.org> wrote:
>> * Changed security/auth/callback/TextCallbackHandler/Password.java to run
>> with JTReg, now the dialog box with instructions will appear as a ui
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> typos
Since you have a different fix now, please update the bug title.
test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java line
55:
> 53: PasswordCallback nc2 = new PasswordCallback("Visible: ", true);
> 54: System.out.println("Two passwords will be prompted for. The first
> one " +
> 55: "should have echo off, the second one on. Otherwise, this
> test fails");
After “will be prompted for”, add a phrase like “enter something at each prompt
and press Enter/Return.” This ensures users don’t simply press Enter and end up
seeing nothing. You can also add a blank line after this to make the paragraph
stand out more.
test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java line
72:
> 70:
> 71: boolean testFailed = new Password().validate(
> 72: "Please copy and execute the following script in the
> terminal/cmd, " +
"the terminal/cmd" -> "a terminal/cmd window".
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22951#issuecomment-2610214579
PR Review Comment: https://git.openjdk.org/jdk/pull/22951#discussion_r1927228355
PR Review Comment: https://git.openjdk.org/jdk/pull/22951#discussion_r1927231445
