On Sat, 25 Jan 2025 01:12:01 GMT, Alexey Bakhtin <abakh...@openjdk.org> wrote:

>> Tim Jacomb has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Revert unneeded change
>
> test/jdk/java/security/KeyStore/CheckMacOSKeyChainIntermediateCATrust.java 
> line 48:
> 
>> 46:  * @summary Check whether loading of certificates from macOS Keychain 
>> correctly
>> 47:  *          loads intermediate CA certificates
>> 48:  * @run junit/manual CheckMacOSKeyChainIntermediateCATrust
> 
> I think you can add negative tests also. E.g. add Root CA without trust 
> settings

Thank you for adding the test

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22911#discussion_r1931125889

Reply via email to