On Sat, 8 Feb 2025 05:01:03 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The fix add remaining classes to the testlibrary jar and fix some warnings >> in security-related classes. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > Update make/test/BuildTestLib.gmk > > Co-authored-by: Erik Joelsson <37597443+erik...@users.noreply.github.com> make/test/BuildTestLib.gmk line 61: > 59: > 60: ifeq ($(call isTargetOs, linux), false) > 61: EXCLUDE_DIRS := jdk/test/lib/containers Please call this either just "EXCLUDES", or even better `BUILD_TEST_LIB_JAR_EXCLUDES` (to conform with existing practice). Changing the name like this sounds like it is going to be assigned to another argument; we have various ways to exclude files and `EXCLUDES` is only one. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23525#discussion_r1949903110
