On Thu, 13 Feb 2025 19:34:04 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Jamil Nimeh has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix JBS ID and summary in test
>
> test/lib/jdk/test/lib/security/CertificateBuilder.java line 462:
>
>> 460: throws CertificateException, IOException,
>> NoSuchAlgorithmException {
>> 461:
>> 462: AlgorithmId signAlg;
>
> This variable looks like it is unused now.
It's used on 476 for encoding the AlgorithmIdentifier of the certificate
signature, and also on 530 to again provide that same AlgorithmIdentifier
encoding in the TBSCertificate strructure.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23566#discussion_r1955313651
