On Tue, 18 Feb 2025 17:52:14 GMT, Rajan Halade <[email protected]> wrote:
>> Fernando Guallini has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8349492
>> - updated wording in KeytoolOpensslInteropTest
>> - updated wording
>> - provider path depends on platform
>> - typo
>> - it should be isX64 rather than is64bit
>> - refactoring
>> - using openssl 3.0.14
>
> test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 80:
>
>> 78: // since the current version of openssl is not available,
>> skip all
>> 79: // openssl command dependent tests with a warning
>> 80: System.out.println("\n\u001B[31mWarning: Can't find the
>> current version "
>
> It will be better to update this to print
> `OpensslArtifactFetcher.OPENSSL_BUNDLE_VERSION` with the corresponding
> `getTestOpenSSLBundleVersion` routine in `OpensslArtifactFetcher`. The
> current version verbiage is confusing.
Ok thanks, updated with suggestions
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23613#discussion_r1962053922
