On Thu, 20 Feb 2025 21:49:49 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally >> with two additional commits since the last revision: >> >> - 8328914: Document the java.security.debug property in javadoc >> - 8328914: Document the java.security.debug property in javadoc > > src/java.base/share/classes/java/security/doc-files/security-related-system-properties.html > line 66: > >> 64: which determines what trace messages are printed during >> execution. >> 65: To view security properties, security providers, and TLS-related >> settings, >> 66: specify the -XshowSettings:security option in the java command. > > This sentence seems out-of-place here. While I think it is useful to mention > this, it has nothing to do with the `java.security.debug` property, so it > seems a little confusing, and I suggest we not include it right now. Perhaps > we can add another section on security related VM options later. Removed. > src/java.base/share/classes/java/security/doc-files/security-related-system-properties.html > line 67: > >> 65: To view security properties, security providers, and TLS-related >> settings, >> 66: specify the -XshowSettings:security option in the java command. >> 67: You can enable debugging in JGSS and other related technologies >> with various system properties or environment variables. > > This is referring to other system properties like `sun.security.jgss.debug`. > Since we are not documenting those other properties here (yet), we should > remove this sentence. Removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23569#discussion_r1964539681 PR Review Comment: https://git.openjdk.org/jdk/pull/23569#discussion_r1964539551
