On Fri, 21 Feb 2025 20:51:11 GMT, Fernando Guallini <[email protected]>
wrote:
>> The test javax/crypto/CryptoPermissions/InconsistentEntries.java uses
>> CDSTestUtils.clone to copy the JDK into the scratch dir by creating symbolic
>> links, but this was seen to crash the VM in Windows Server 2025. To ensure
>> test stability, it should hard copy the required files.
>
> Fernando Guallini has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated comment with runtimeException
Marked as reviewed by rhalade (Reviewer).
test/lib/jdk/test/lib/util/FileUtils.java line 377:
> 375: * @param dst the path of the destination directory
> 376: * @throws IOException
> 377: * if an I/O error occurs
Suggestion:
* @throws RuntimeException if an I/O error occurs during the copy operation
* or if the source or destination paths are invalid
-------------
PR Review: https://git.openjdk.org/jdk/pull/23726#pullrequestreview-2634146048
PR Review Comment: https://git.openjdk.org/jdk/pull/23726#discussion_r1966126842
