Re: RFR: 8325448: Hybrid Public Key Encryption [v3]

[Kevin Driver]

On Thu, 27 Feb 2025 03:22:18 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/.
>> 
>> ![HPKEParameterSpec](https://github.com/user-attachments/assets/4f64567a-59b0-473e-8a3b-416565f5bca5)
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   example and KAT

src/java.base/share/classes/com/sun/crypto/provider/HPKE.java line 101:

> 99:     @Override
> 100:     protected AlgorithmParameters engineGetParameters() {
> 101:         return null;

In traditional JCE, wouldn't we return a representation of the 
`HPKEParameterSpec` which extends `AlgorithmParameters`?

src/java.base/share/classes/com/sun/crypto/provider/HPKE.java line 112:

> 110:             // Parent spec says "throws InvalidKeyException if the given 
> key
> 111:             // requires algorithm parameters that cannot be determined 
> from
> 112:             // the given key"

Thanks for including this comment! :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r1975671709
PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r1975673234