On Wed, 12 Mar 2025 13:50:06 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:

>> test/lib/jdk/test/lib/artifacts/ArtifactResolver.java line 103:
>> 
>>> 101:                 message = "Cannot find the artifact " + 
>>> artifact.name();
>>> 102:             } else {
>>> 103:                 message = "Class " + klass.getName() + " missing 
>>> @Artifact annotation.";
>> 
>> I assume it's a bug if `klass` is not annotated with `@Artifact`. I'd rather 
>> throw an NPE here so we can notice it.
>
> Do you mean to just assume `artifact` is never null and let the NPE be thrown 
> if it is?

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23989#discussion_r1991830403

Reply via email to