On Fri, 21 Mar 2025 13:59:10 GMT, Andrew Dinn <ad...@openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Fixed mismerge. >> - Merged master. >> - A little cleanup >> - Merged master >> - removing trailing spaces >> - kyber aarch64 intrinsics > > src/hotspot/share/opto/library_call.cpp line 7800: > >> 7798: const char *stubName; >> 7799: assert(UseKyberIntrinsics, "need Kyber intrinsics support"); >> 7800: assert(callee()->signature()->size() == 3, "kyber12To16 has 3 >> parameters"); > > Just as an aside this causes testing of a debug build to fail. The intrinsic > has 4 parameters. With this value reset to 4 the ML_DSA test passes for ML_KEM on a debug build. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23663#discussion_r2007642721
