On Thu, 27 Mar 2025 13:28:57 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Not split warning in rb.getString() accross multi-lines for Usages.java > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line > 1137: > >> 1135: >> 1136: private void crossCheckEntries(String jarName) throws Exception { >> 1137: List<String> locEntries = new ArrayList<>(); > > I think this can be a `HashSet` now that you don't care about the order when > checking against the `cenEntries` later. Changed to `HashSet`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23532#discussion_r2017446934