On Tue, 25 Mar 2025 15:38:02 GMT, Hai-May Chao <hc...@openjdk.org> wrote:

>> Update the SSLHandshake benchmark to enable running in multiple threads.
>> 
>> This PR changes the scope of the state from per-benchmark to per-thread. The 
>> server SSLContext is still shared across all threads to simulate the 
>> scenario where multiple clients try to connect to the same server at the 
>> same time.
>> 
>> Before the change, running this benchmark with `make test 
>> TEST=micro:SSLHandshake MICRO=OPTIONS="-t 3"` failed with an exception. 
>> After this change the benchmark completes successfully.
>
> Changes look good.

Thanks @haimaychao for the review!

Can I get a second review please?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24195#issuecomment-2768403907

Reply via email to