On Fri, 11 Apr 2025 10:45:20 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing white spaces
>
> src/java.base/share/classes/java/net/HttpURLConnection.java line 617:
>
>> 615: * {@link java.security.AllPermission}.
>> 616: */
>> 617: @Deprecated(since = "25")
>
> can this (and all other getPermission methods) be "forRemoval=true"?
Possibly. @AlanBateman may have some thoughts on this.
> src/java.base/share/classes/java/net/SocketPermission.java line 1311:
>
>> 1309:
>> 1310: @SuppressWarnings("removal")
>> 1311: @Deprecated(since = "25", forRemoval = true)
>
> this class is internal, no need to deprecate
It helps getting warnings at the place where the class is used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24592#discussion_r2039358351
PR Review Comment: https://git.openjdk.org/jdk/pull/24592#discussion_r2039360730
