Re: RFR: 8325448: Hybrid Public Key Encryption [v14]

[Sean Mullan]

On Wed, 2 Apr 2025 20:35:29 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/.
>> ![hpke](https://github.com/user-attachments/assets/4edc5d08-ef52-44c5-b5d5-e8890c2d2fce)
>
> Weijun Wang has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - put encapsulation in params from getParameters
>  - receiver must specify all algorithm identifiers

src/java.base/share/classes/com/sun/crypto/provider/HPKEParameters.java line 88:

> 86:     @Override
> 87:     protected String engineToString() {
> 88:         return "HPKE";

Should you also return what is in the `HPKEParameterSpec`? I think that would 
be more compliant with the method description.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2039923948