On Mon, 14 Apr 2025 12:26:09 GMT, Ferenc Rakoczi <d...@openjdk.org> wrote:
>> @ferakocz Hi Ferenc. Thank you for adjusting the code as requested and even >> more so for the extra clean-ups you added which I very much appreciate. >> >> I have added suggestions for some extra/modified commenting to clarify >> certain details of what is being generated that were not 100% clear to me >> when I first read/restructured the code. They may seem a bit obvious but I >> want to ensure that any maintainer who needs to review the code can >> assimilate it quickly (including me if/when I revisit it in 12 months time). >> >> Mostly my recommendations for upgrading of comments is complete and I >> believe little more will be needed to sign off this PR. However, I still >> want to check through a few parts of the code that I have not fully >> cross-checked against the Java routines (e.g. the Barrett reductions). I'll >> try to do that asap but it will probably be a few days from now. >> >> Thanks again for your help in improving this code. > > @adinn Hi, Andrew, > I think I addressed all of your comment improvement comments, in most cases > I just changed them as you suggested. Thanks a lot for the thorough review! @ferakocz Hi Ferenc, Sorry, but I still had a few comments to add to the KyberNTTMult routine to clarify exactly how the load, compute and store operations relate to the original Java source. That's the only remaining code that I felt needed further clarification for maintainers. So, after you work through them I can approve the PR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23663#issuecomment-2805488504
