On Thu, 17 Apr 2025 03:14:14 GMT, Martin Balao <mba...@openjdk.org> wrote:
>> Hi, >> >> I would like to request a review for the fix of JDK-8350661. In this fix, we >> translate the native PKCS 11 error code into an >> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` >> API. With that said, different PKCS 11 libraries may throw different errors >> and may even (in theory) delay the error until the key is used, as _SunJCE_ >> does. I believe that this is an improvement but further adjustments may be >> needed in the future. >> >> No regressions observed in `test/jdk/sun/security/pkcs11/KDF/TestHKDF.java`. >> >> Thanks, >> Martin.- > > Martin Balao has updated the pull request incrementally with one additional > commit since the last revision: > > Inform key sizes in the exception when failing check. src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java line 605: > 603: } > 604: } > 605: } Hmm, how about separating out AES, RC4, Blowfish and ChaCha20 to a separate case? Only DES and DES3 needs parity checking and they are very legacy. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24526#discussion_r2049737012
