On Fri, 21 Mar 2025 12:00:57 GMT, Fernando Guallini <fguall...@openjdk.org> 
wrote:

>> The following tests are marked with @ignore (not running):
>> 
>> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting 
>> the clientMode after the handshake has begun is not permitted, but this was 
>> failing intermittently due to a race condition, it was possible that 
>> SetClientMode was called before the client socket was updated with handshake 
>> isNegotiated = true. The fix is to introduce a latch to sync between client 
>> and main threads. Included additional refactoring to ensure test stability.
>> 
>> - sun/security/ssl/SSLSocketImpl/NonAutoClose.java: This test should only 
>> run in TLS <= 1.2, as TLSv1.3 changes the behaviour of close_notify. 
>> Included additional refactoring to ensure test stability.
>> 
>> Executed both tests 10K times, no test flakiness found
>
> Fernando Guallini has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   using assertThrows

Please, this needs a reviewer's approval

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23898#issuecomment-2829754170

Reply via email to