On Tue, 29 Apr 2025 13:08:36 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comment from Sean > > src/java.base/share/classes/javax/crypto/spec/RC2ParameterSpec.java line 107: > >> 105: if (offset < 0) { >> 106: throw new ArrayIndexOutOfBoundsException("offset is >> negative"); >> 107: } > > Move these lines before line 104 as `blocksize` doesn't need to be set until > after this check. done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24854#discussion_r2066923298