On Wed, 30 Apr 2025 03:21:19 GMT, Koushik Muthukrishnan Thirupattur <d...@openjdk.org> wrote:
>> The private marshal() method in sun.security.util.Debug still contains code >> to parse "permission=<classname>" and "codebase=<URL>" options. These >> sub-options were part of the "access" option which was removed in JDK 24 as >> part of JEP 486, so this code can be removed. > > Koushik Muthukrishnan Thirupattur has updated the pull request incrementally > with one additional commit since the last revision: > > 8353001:Remove leftover Security Manager parsing code in > sun.security.util.Debug src/java.base/share/classes/sun/security/util/Debug.java line 369: > 367: "[a-zA-Z_$][a-zA-Z0-9_$]*([.][a-zA-Z_$][a-zA-Z0-9_$]*)*"; > 368: Pattern pattern = Pattern.compile(reg); > 369: Matcher matcher = pattern.matcher(source); You can remove the import of `Matcher` as it is no longer used. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24731#discussion_r2068557271
