On Thu, 1 May 2025 10:31:20 GMT, Mikhail Yankelevich <myankelev...@openjdk.org> 
wrote:

>> * Changed the test to use scratch directory
>> * Cleaned up the imports
>
> Mikhail Yankelevich has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   changed file creation to use Utils.createTempFile

test/jdk/sun/security/pkcs12/P12SecretKey.java line 88:

> 86:                                    " keystore");
> 87:             } else {
> 88:                 System.err.println("ERROR: keys are NOT equal after 
> storing in "

Test should fail here, throw RuntimeException.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24718#discussion_r2070416780

Reply via email to