On Fri, 2 May 2025 06:09:52 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features does >> not permanently define the API and it is subject to change in future >> releases until it is finalized. >> >> Details about this change can be seen at [PEM API >> JEP](https://bugs.openjdk.org/browse/JDK-8300911). >> >> Thanks >> >> Tony > > Anthony Scarpino has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 66 commits: > > - major code review comments update > - Merge branch 'master' into pem > - Merge branch 'master' into pem > - javadoc updates > - code review comments > - merge with master > - better comment and remove commented out code > - Merge branch 'master' into pem > - Merge branch 'pem-merge' into pem > - merge > - ... and 56 more: https://git.openjdk.org/jdk/compare/e2ae50d8...0c540327 src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java line 362: > 360: * @throws InvalidKeyException on decoding failure > 361: */ > 362: nit: remove blank line src/java.base/share/classes/sun/security/x509/X509Key.java line 354: > 352: } catch (NoSuchAlgorithmException | InvalidKeySpecException e) { > 353: // Ignore and return raw key > 354: throw new IOException("error with encoding"); How about also including the cause? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2071878794 PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2071885225
