On Fri, 9 May 2025 16:42:31 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into deprecate-net-perms-8353642
>> - Revert changes to SocketPermission and CodeSource
>> - Review feedback. Deprecate getPermission for removal.
>> - Missing white spaces
>> - 8353642: Deprecate networking permission classes for removal
>
> src/java.base/share/classes/java/net/HttpURLConnection.java line 615:
>
>> 613: */
>> 614: @Deprecated(since = "25", forRemoval = true)
>> 615: @SuppressWarnings("removal")
>
> Do you still need this annotation now that `SocketPermission` is not
> deprecated for removal?
Ah - good point - I will double check.
> src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
> line 214:
>
>> 212: */
>> 213: @Override
>> 214: @Deprecated(since = "25", forRemoval = true)
>
> Is this annotation required or more as a reminder that the superclass method
> is deprecated?
I think it's needed because the superclass method is deprecated for removal.
Will double check.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24592#discussion_r2082374190
PR Review Comment: https://git.openjdk.org/jdk/pull/24592#discussion_r2082374078
