On Sat, 10 May 2025 02:10:14 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review feedbacks from Brad.
>
> src/java.base/share/classes/sun/security/util/KeyUtil.java line 451:
>
>> 449: || alg.equalsIgnoreCase("Generic");
>> 450: }
>> 451:
>
> As you know, I've been working on the [TLS Exporters change](
> https://github.com/openjdk/jdk/pull/24976) which will use the same KDF APIs.
> I've already updated that to use your style.
>
> Looks like I've now got one more thing to change! ;)
This is a reply to the comment above. I don't know why GitHub does not show a
reply box there.
> Is any specific salt needed here like in TLS?
In DHKEM, the salt used is always empty.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24393#discussion_r2083209459
