On Tue, 13 May 2025 09:27:37 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features does >> not permanently define the API and it is subject to change in future >> releases until it is finalized. >> >> Details about this change can be seen at [PEM API >> JEP](https://bugs.openjdk.org/browse/JDK-8300911). >> >> Thanks >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > comments on the 11th src/java.base/share/classes/sun/security/ec/ECPrivateKeyImpl.java line 228: > 226: ECOperations ops = ECOperations.forParameters(ecParams) > 227: .orElseThrow(ProviderException::new); > 228: MutablePoint pub = ops.multiply(ecParams.getGenerator(), arrayS); Can `arrayS` ever be `null` here? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2086758373
