On Mon, 12 May 2025 14:35:45 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comments on the 11th > > src/java.base/share/conf/security/java.security line 1560: > >> 1558: # withEncryption method. >> 1559: # >> 1560: jdk.epkcs8.defaultAlgorithm=PBEWithHmacSHA256AndAES_128 > > What about naming this `jdk.pem.pbeAlgorithm`? The `withEncryption` method > never mentions PKCS#8, so maybe don't need to expose this in the property > name. Also having "pem" in the property name makes it more clear what API > this property is used for. The security property is not just PEMEncoder/PEMDecoder, it also affects EKPI. So slightly less PEM specific. I'm open to change it if we need to ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2088115825
