On Wed, 21 May 2025 06:50:28 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> encrypt() should return an empty byte array on failure
>
> src/java.base/share/classes/sun/security/ssl/SessionTicketExtension.java line
> 304:
>
>> 302: private static byte[] compress(byte[] input) throws IOException
>> {
>> 303: ByteArrayOutputStream baos = new ByteArrayOutputStream();
>> 304: GZIPOutputStream gos = new GZIPOutputStream(baos);
>
> you lost the try-with-resources in your last push; please bring it back.
Done, thanks.
> src/java.base/share/classes/sun/security/ssl/SessionTicketExtension.java line
> 323:
>
>> 321: input.get(bytes);
>> 322:
>> 323: GZIPInputStream gis = new GZIPInputStream(
>
> same here, please restore the try-with-resources
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25310#discussion_r2100468033
PR Review Comment: https://git.openjdk.org/jdk/pull/25310#discussion_r2100468322
