On Fri, 30 May 2025 15:57:09 GMT, Anthony Scarpino <ascarp...@openjdk.org> 
wrote:

>> I need a code review to throw `InvalidKeySpecException` when null is passed 
>> with `generatePublic()` and `generatePrivate()`.  This change takes the 
>> opportunity to modernize the KeyFactory code by using `switch` syntax for 
>> `instanceof` checking, as well as, keeping the previous design of the 
>> implementation method handling the null case.  There are existing JCK test 
>> cover this case, so no regression test is added.
>
> Anthony Scarpino has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   most should be must

Marked as reviewed by weijun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25533#pullrequestreview-2882406471

Reply via email to