On Tue, 3 Jun 2025 07:55:06 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:

>> Passes the `Charset` read from the `stdin.encoding` system property while 
>> creating `InputStreamReader` or `Scanner` instances for `System.in`.
>> 
>> `stdin.encoding` is a recently added property for Java 25 in 
>> [JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703). Employing it 
>> throughout the entire code base is addressed by the parent ticket 
>> [JDK-8356893](https://bugs.openjdk.org/browse/JDK-8356893). JDK-8357995 this 
>> PR is addressing is a sub-task of JDK-8356893 and is concerned with only 
>> areas related to core libraries.
>
> Volkan Yazici has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix missing `java.io.Reader` import in `Ktab`

Personally I think both 2 and 3 are good. However, I'm totally OK with keeping 
your current code if no one else think it's worth a rewrite.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25544#issuecomment-2936969327

Reply via email to