On Wed, 4 Jun 2025 14:59:43 GMT, Weijun Wang <wei...@openjdk.org> wrote:

> Add more comment on why `KeyUtil::getKeySize` could return -1. Add a new 
> method `getNistCategory` to get the NIST security category.

src/java.base/share/classes/sun/security/util/KeyUtil.java line 56:

> 54:      * Traditionally, the key size of an asymmetric key refers to the 
> size of
> 55:      * its modulus. For example, a 2048-bit RSA key or a 256-bit NIST 
> P-256 EC
> 56:      * key. However, modern post-quantum algorithms based on lattice 
> cryptography,

I would not say "modern post-quantum".

src/java.base/share/classes/sun/security/util/KeyUtil.java line 134:

> 132: 
> 133:     /**
> 134:      * Returns the NIST security categories defined for PQC algorithms. 
> It was

s/was/is/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25642#discussion_r2126930677
PR Review Comment: https://git.openjdk.org/jdk/pull/25642#discussion_r2126940503

Reply via email to