On Wed, 23 Feb 2022 20:15:24 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
> Hi, > > Please review the implementation of RFC 8879, TLS Certificate Compression, in > JDK. The TLS Certificate Compression standard is an essential part for QUIC > connections and performance improvement for TLS connections. More details, > please refer to the [JEP](https://bugs.openjdk.java.net/browse/JDK-8281710) > proposal. > > The JEP was submitted, and it may take time for the final approval. But let > me know you ideas and concerns about the proposal and implementation. > > JEP: https://bugs.openjdk.java.net/browse/JDK-8281710 test/jdk/javax/net/ssl/HttpsURLConnection/HttpsCompressedCert.java line 64: > 62: public static void main(String[] args) throws Exception { > 63: SSLParameters sslParameters = new SSLParameters(); > 64: sslParameters.setCertificateInflaters(Map.of("brotli", > certInflater)); Why `brotli` compression is being requested here when JDK doesn't support it? Looks like Google doesn't send a compressed certificate back, that's why this test works, the supplied `certInflater` function is using ZLIB. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/7599#discussion_r2136560698